The selection of themes can use some improvements that will make it easier to view the currently active theme, as well as choosing color schemes, and the improvements make it so that the available themes for choosing use the available space in a more efficient manner.
I'm leaving this ticket open pending Bchan's review.
Bchan, here are some notes:
I am committing this so that it's in svn, but if it needs a rollback, please feel free.
Here are the possible issues I see so far that I will need you to either change, or help me fix them:
- I replaced the table-iterator taglib with a regular while loop. Using a UL allows us to take up more space for the list, and gives a flexible horizontal space (whereas in the table-iterator, the columns are hardcoded).
Since it's a generic loop, however, there is some duplication of HTML. I'm not sure if you want to make another taglib for a generic iterator that takes the same type of content as table iterator but just iterates without tables.
- I put the css in the css.jsp for portlet/communities, and referenced it in the liferay-portlet.xml in both the communities portlet entry and the layout_management entry. Not sure if this is okay but I'll let you tell me.
- I will be creating the lfr-panel portion into a taglib, but I wanted to make sure the html/css made it into svn one way or another so it doesn't slip under my radar.
- I need a way to get the URL for the "Download More" link that points to where a user can download more themes.
I think that's about it. Please let me know if there are any questions/concerns, etc.