WorkflowHandlerRegistryUtil doesn't take into account service.ranking

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, Master
• Fix Version/s: 7.0.0 DXP FP91, 7.0.10.14 DXP SP14, 7.0.X, 7.1.10 DXP FP18, 7.1.10.5 SP5, 7.1.X, 7.2.10 DXP FP5, 7.2.10.2 DXP SP2, 7.2.X, 7.3.1 CE GA2, 7.3.2 CE GA3, 7.3.10 DXP GA1, Master
• Component/s: Workflow
• Labels:
  • INACTIVE
  • ee-ts
  • liferay-dxp-70-sp14
  • liferay-dxp-71-sp5
  • liferay-dxp-72-sp2
  • liferay-fixpack-de-91-7010
  • liferay-fixpack-dxp-18-7110
  • liferay-fixpack-dxp-5-7210
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/shuyangzhou/liferay-portal/pull/8956

Steps to Reproduce:

1. Create a custom module adding CustomJournalWorkflowHandler.
2. Deploy the module in the server.
3. Restart the server.
4. Execute the following Groovy script and check that CustomJournalWorkflowHandler appears.

for(wh in com.liferay.portal.kernel.workflow.WorkflowHandlerRegistryUtil.getWorkflowHandlers()) {
    out.println(wh);
}

 

Expected Result:

CustomJournalWorkflowHandler should appear as it has higher service ranking than JournalArticleWorkflowHandler.

 

Actual Result:

JournalArticleWorkflowHandler appears as we are using a map to save the handlers ignoring the priority.