Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-110344

Update BNDBundleCheck to allow Liferay-Releng-Restart-Required: false

    Details

      Description

      In app.bnd, allow "false" for Liferay-Releng-Restart-Required if a POSHI test exists.

      The POSHI test case must have the property hot.deploy.osgi.app.includes set to the name of the app you want to hot deploy.

      Notes for the development of the SF check:
      For {module_name}/app.bnd where Liferay-Releng-Restart-Required: false

      1. Search .testcase files in portal-web/test/functional/com/liferay/portalweb/tests
      2. Look for "hot.deploy.osgi.app.includes"
        1. The value of this property will be the name of the module being tested
        2. List all values wherever this property is set
      3. Check if {module_name}

        is on the list

        1. If {module_name} is on the list, success
        2. If {module_name} is not on the list, SF changes the value back to true and displays a message. Suggested:
          Liferay-Releng-Restart-Required can only be set to false if a POSHI tests exists. See LPS-110344.

      Examples:
      https://github.com/liferay/liferay-portal/blob/master/portal-web/test/functional/com/liferay/portalweb/tests/coreinfrastructureee/search/elasticsearch/Elasticsearch6EE.testcase#L685
      https://github.com/liferay/liferay-portal/blob/master/portal-web/test/functional/com/liferay/portalweb/tests/coreinfrastructureee/search/elasticsearch/Elasticsearch7EE.testcase#L818
      https://github.com/liferay/liferay-portal/blob/master/portal-web/test/functional/com/liferay/portalweb/tests/coreinfrastructure/search/elasticsearch/Elasticsearch7.testcase#L219

      Additional related tasks:

      1. Set Liferay-Releng-Restart-Required: false for modules/dxp/apps/portal-search-learning-to-rank
      2. Remove suppression for modules/apps/portal-search-elasticsearch7 (revert 6cc4197f146daa5cfcc0f57c7f36a27407c2fba0)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              hugo.huijser Hugo Huijser
              Reporter:
              jason.pince Jason Pince
              Engineering Assignee:
              Alan Huang
              Recent user:
              Jason Pince
              Participants of an Issue:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  Master