Inactive sites returns a 404 instead of a proper error message

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.1.X, 7.2.X, Master
• Fix Version/s: 7.1.10 DXP FP18, 7.1.10.5 SP5, 7.1.X, 7.2.10 DXP FP5, 7.2.10.2 DXP SP2, 7.2.X, 7.3.10 DXP GA1, Master
• Component/s: ~ [Archived] Sites Management
• Labels:
  • ee-ts
  • liferay-dxp-71-sp5
  • liferay-dxp-72-sp2
  • liferay-fixpack-dxp-18-7110
  • liferay-fixpack-dxp-5-7210
• Branch Version/s:
  7.2.x, 7.1.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/86884

Reproduction steps:

1. Start a Vanilla DXP 7.1 (FP-15)
2. Create a "Test" Site
3. Create a new page "Home"
4. Access the home page, note that verything works properly
5. Deactivate the site in Site Settings
6. Try to access the site again -> you will get a white non customizable 404 Page cannot be found (Existing INACTIVE site.PNG)
7. Try to access a RANDOM nonexistent site like web/randomsite (Nonexistent site.PNG)
8. Observe that you get a nice, styled 404 error message, which implies that the site couldn't be found

For some reason, the nonexistent pages are being handled differently. This white 404 default error cannot be either styled nor handled. This behaviour is not consistent.

 Reproduced on
7.1.x 22d99711f8bc6321afcd5110b430271114096830
master a50b7ce4acf06f0c2728dbcc104069223dd2071d

There was a previous attempt to fix this issue: LPS-84414, but it produced LPS-84695 as regression. This solution does not have this regression.