Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-110482

Using LanguageExtender with more than 2 contributing modules, causes stackoverflow

    Details

      Description

      LanguageExtender can be used to extend & override language keys of any module using the resource.bundle.aggregate:String in the directive. 

      In the past you could aggregate on aggregates by registering additional modules, and the implementation would work out the natural ordering based on the provided service.ranking of each. However, this protection appears to have been removed (maybe replaced?) and the result is an infinite loop caused by the aggregates bouncing off each other.

      The method that previously handled this situation: https://github.com/brianchandotcom/liferay-portal/pull/74202/files#diff-63df9d457c8af0bbf67c211014dc9b77L329

      To reproduce, deploy a module with the attached bnd.bnd and then navigate to the SAML Admin portlet in control panel. (reproduced on master, commit 9876741a)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              summer.zhang Summer Zhang
              Reporter:
              stian.sigvartsen Stian Sigvartsen
              Participants of an Issue:
              Recent user:
              Zendesk for JIRA
              Engineering Assignee:
              Preston Crary
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 30 weeks, 4 days ago

                  Packages

                  Version Package
                  7.3.10 DXP GA1
                  Master