Review emails should only be sent for the latest Web Content version

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.1.X, 7.2.X, Master
• Fix Version/s: 7.1.10 DXP FP18, 7.1.10.5 SP5, 7.1.X, 7.2.10 DXP FP5, 7.2.10.2 DXP SP2, 7.2.X, 7.3.10 DXP GA1, Master
• Component/s: Mail, ~[Archived] WCM > Publication
• Labels:
  • ee-ts
  • liferay-dxp-71-sp5
  • liferay-dxp-72-sp2
  • liferay-fixpack-dxp-18-7110
  • liferay-fixpack-dxp-5-7210
• Branch Version/s:
  7.2.x, 7.1.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/ealonso/liferay-portal/pull/2880

Description
If we create a Web Content article with the Review Date: 03/24/2020 - 08:00 and then Publish, at 08:15 it would be picked up by the Check Interval setting. Before 08:15 comes, if we change the Review Date to 03/24/2020 - 08:45, the user still receives email notification for the original 08:15 configuration.

Steps to Reproduce
1. Add a portal-ext.properties file with these settings

:

admin.email.from.name=Joe Bloggs
admin.email.from.address=[e-mail]

3. Configure a SMTP outbound email server.
4. Start Liferay DXP > Sign in
.
5. Server Administration > Mail > Configure outbound SMTP settings to connect to your SMTP outbound email server.
6. Go to Server Administration > Log Levels and add the following logging categories - set all 3 to DEBUG:

com.liferay.journal.service.impl.JournalArticleLocalServiceImpl
com.liferay.portal.kernel.util.SubscriptionSender
com.liferay.mail.messaging.MailMessageListener

7. Lower the Check Interval timing.
Control Panel > Configuration > System Settings > Web Content > Check Interval [1 minutes]
8. Create a Basic Web Content item called "Test".
9. Set a Review Date that is 2 min in the future then Publish. Quickly change the Review Date to 1 year in the future (2021) and Publish again. (In the real world, the user has made a mistake and needs to fix the Review Date.) Wait 2-3 minutes
.

Expected Result
A review notification email would now only be received in 1 years' time

Actual Result
Email is still received as per the Review Date when the article was first published

Notes
Please note that the Review Date default is DECEMBER 2020, please change to the current month when configuring.

If you're restarting the portal, make sure to re-add the logging categories mentioned in step 6.

Reproduced in:
7.1.x: bfea590ac796bada7a3ab7cb8994d58e5943be34
7.2.x: 426dd5b3f5ab9f871f653e6331c70783198e261a
master: d1b4312c498beb86aa3101320d4057ecdf538928

Thank you!