Details

    • Technical Testing
    • Status: Closed
    • Minor
    • Resolution: Completed
    • None
    • None
    • JS APIs and Utilities
    • S03E24 - Wuhan, S03E28 - New York, S03E29 - Como

    Description

      Lexicon defines a set of best practices and guidelines to work with Modals. Based on those recommendations, Clay offers a rich set of Modal components that can be used to implement such Patterns.

      The goal of this epic is to update the current Modal Patterns in DXP to match Lexicon's recommendations as much as possible.

      1. Modal follows Lexicon Patterns

      Given DXP

      When a modal is opened in some part of the product

      Then the following is true:

      • The modal window is not full-size for non-iframe modals
      • When a modal has a footer, the actions are inside and right aligned
      • A modal with a footer displays actions in this order (from left to right): borderless button, secondary button and primary button.

      Test Scenarios

      Test Scenarios Test Strategy Kind of test Is it covered by FrontEnd ? (JS-Unit) Is it covered by BackEnd ? (unit or integration)
      Validate in Fragments, when modal is open, then the modal window is full-size for iframe modals Sanity Manual  No  No
      Validate in Sign In, when modal is open, then the modal window is not full-size for non-iframe modals Smoke Manual  No  No
      Validate an existing usecase when a modal has a footer, then actions are inside the footer are right aligned - see https://issues.liferay.com/browse/LPS-109100 for an example usecase with footer Regression Manual  No  No
      Validate an existing usecase when a modal has a footer, then the actions are shown in the following order (from left to right): borderless button, secondary button and primary button. Regression Manual  No  No

      Remember to run them on different browsers:

      Type Firefox IE11 Chrome Edge
      Smoke
      Sanity  
      Regression    

      Please comment results in table format. Use LPS-108732 comment as a template.

      Attachments

        Issue Links

          Activity

            People

              john.co John Co
              john.co John Co
              Kiyoshi Lee Kiyoshi Lee
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Packages

                  Version Package