Details

      Description

      Epic Information

      There's currently a good amount of JSP tags owned by the Frontend Infrastructure team that are unused (and in most cases deprecated).

      While these tags don't require a good deal of maintenance, having a big list of tags in many cases with similar names makes it really hard for users (both internal and external) to have a clear understanding of what to use to build applications.

      The goal of this epic is to remove unused and deprecated JSP tags.

      Acceptance Criteria

      • All deprecated and unused tags in liferay-ui.tld are removed
      • All deprecated and unused tags in aui.tld are removed
      • All deprecated and unused tags in liferay-theme.tld are removed
      • The clay:table is removed

      Additional Considerations
      The following tags, while deprecated are still used and can't be removed without previously updating the usages which will have to be done in a followup epic:

      Tag Usages
      liferay-ui:app-view-search-entry wiki-web/src/main/resources/META-INF/resources/wiki/search.jsp
      liferay-ui:app-view-search-entry wiki-web/src/main/resources/META-INF/resources/wiki/search.jsp
      liferay-ui:asset-categories-selector portal-web/docroot/html/taglib/aui/input/page.jsp
      liferay-ui:asset-categories-summary site-navigation-directory-web/src/main/resources/META-INF/resources/view.jsp
      liferay-ui:asset-tags-selector portal-web/docroot/html/taglib/aui/input/page.jsp
      liferay-ui:asset-tags-summary site-navigation-directory-web/src/main/resources/META-INF/resources/view.jsp
      liferay-ui:breadcrumb (More than 1)
      liferay-ui:input-editor (More than 1)
      liferay-ui:input-scheduler portal-reports-engine-console-web/src/main/resources/META-INF/resources/admin/report/edit_schedule.jsp
      liferay-ui:toggle portal-web/docroot/html/taglib/ui/toggle_area/start.jsp
      liferay-ui:toggle-area (More than 1)
      user-group-search-container-results roles-selector-web/src/main/resources/META-INF/resources/edit_roles_user_groups.jsp

      Test Information

      Test Scenarios

      Requirement Test Scenarios Test Priority (business impact) Covered by frontend/backend Unit Test?
      LPS-112476 Given portal master 7.4
      When I navigate to the folder: portal/portal-web/docroot/html/taglib/ui/
      Then will not find: table_iterator AND user_search_container_results AND user_search_form AND ratings AND search_speed AND toggle_area AND toggle with AND input_scheduler with the jsps of the tag
      3-medium no
      LPS-122938 Given portal bundle master 7.4
      When I execute command: grep -r "TableIteratorTag.java" AND execute command: grep -r "search-speed" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122939 Given portal bundle master 7.4
      When I execute command grep -r "UserSearchContainerResultsTag.java" AND execute command: grep -r "user-search-container-results" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122940 Given portal bundle master 7.4
      When I execute command grep -r "UserSearchFormTag.java" AND execute command: grep -r "user-search-form" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-121931 Given portal bundle master 7.4
      When I execute command grep -r "TableTag.java" AND execute command: grep -r "clay:table" * from "clay.tld"
      Then no results are returned
      3-medium no
      LPS-122936 Given portal bundle master 7.4
      When I execute command grep -r "RatingsTag.java" AND execute command: grep -r "ratings " * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122933 Given portal bundle master 7.4
      When I execute command grep -r "AlertTag.java" AND execute command: grep -r "alert " * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122934 Given portal bundle master 7.4
      When I execute command grep -r "OrganizationSearchContainerResultsTag.java" AND execute command: grep -r "organization-search-container-results" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122935 Given portal bundle master 7.4
      When I execute command grep -r "OrganizationSearchFormTag.java" AND execute command: grep -r "organization-search-form definition" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122931 Given portal bundle master 7.4
      When I execute command grep -r "LayoutIconTag.java" AND execute command: grep -r "layout-icon" * from "liferay-theme.tld"
      Then no results are returned
      3-medium no
      LPS-122932 Given portal bundle master 7.4
      When I execute command: grep -r "param" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-122937 Given portal bundle master 7.4
      When I execute command grep -r "SearchSpeedTag.java" AND execute command: grep -r "search-speed" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-123014 Given portal bundle master 7.4
      When I execute command grep -r "ToggleAreaTag.java" AND execute command: grep -r "toggle-area" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-123015 Given portal bundle master 7.4
      When I execute command grep -r "ToggleTag.java" AND execute command: grep -r "toggle" * from "liferay-ui.tld"
      Then no results are returned
      3-medium no
      LPS-123018 Given portal bundle master 7.4
      When I execute command grep -r "InputSchedulerTag.java" AND execute command: grep -r "input-scheduler" * from "liferay-ui.tld" Then no results are returned
      3-medium no
      LPS-122938 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'TableIteratorTag.java' AND 'search-speed' from "liferay-ui.tld'
      3-medium no
      LPS-122939 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'UserSearchContainerResultsTag.java' AND 'user-search-container-results' from 'liferay-ui.tld'
      3-medium no
      LPS-122940 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'UserSearchFormTag.java' AND 'user-search-form' from 'liferay-ui.tld'
      3-medium no
      LPS-121931 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'TableTag.java' AND 'clay:table' from 'clay.tld'
      3-medium no
      LPS-122936 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'RatingsTag.java' AND 'ratings' from "liferay-ui.tld'
      3-medium no
      LPS-122933 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'AlertTag.java' AND 'alert' from 'liferay-ui.tld'
      3-medium no
      LPS-122934 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'OrganizationSearchContainerResultsTag.java' AND 'organization-search-container-results' from 'liferay-ui.tld'
      3-medium no
      LPS-122935 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'OrganizationSearchFormTag.java' AND 'organization-search-form definition' from 'liferay-ui.tld'
      3-medium no
      LPS-122931 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'LayoutIconTag.java' AND 'layout-icon' from 'liferay-theme.tld'
      3-medium no
      LPS-122932 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'param' from 'liferay-ui.tld'
      3-medium no
      LPS-122937 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'SearchSpeedTag.java' AND 'search-speed' from 'liferay-ui.tld'
      3-medium no
      LPS-123014 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'ToggleAreaTag.java' AND 'toggle-area' from 'liferay-ui.tld'
      3-medium no
      LPS-123015 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'ToggleTag.java' AND 'toggle' from 'liferay-ui.tld'
      3-medium no
      LPS-123018 Given opened console terminal in the portal root
      When I execute command: git ls-files | grep BREAKING
      Then I can find info about removed: 'InputSchedulerTag.java' AND 'input-scheduler' from 'liferay-ui.tld'
      3-medium no

      Other tests

      Test Scenario Test Priority (business impact) 
      Given: All changes done (tickets complete)
      When: CI: test relevant
      Then: Poshi tests passed
      4-major

       
      What will not be tested:
      -Browser's and Mobile's manual tets. Changes will be not visible on the UI.
      -Accessibility. Same reason like above.

        Attachments

          Activity

            People

            Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            jose.balsas Chema Balsas
            Recent user:
            Marta Elicegui
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package