ConfigurationPersistenceManager fails when upgrading from <DE-55 and config path includes whitespace

• Type: Regression Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, Master
• Fix Version/s: 7.0.0 DXP FP93, 7.0.10.14 DXP SP14, 7.0.X, 7.1.10 DXP FP18, 7.1.10.5 SP5, 7.1.X, 7.2.10 DXP FP6, 7.2.X, 7.3.3 CE GA4, 7.3.10 DXP GA1, Master
• Component/s: Portal Configuration > System Settings
• Labels:
  • ee-ts
  • liferay-dxp-70-sp14
  • liferay-dxp-71-sp5
  • liferay-fixpack-de-93-7010
  • liferay-fixpack-dxp-18-7110
  • liferay-fixpack-dxp-6-7210
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/shuyangzhou/liferay-portal/pull/9084

Steps to Reproduce:

1. Setup a DXP 7.0 with FP-54 using as Liferay home a path that includes a whitespace, for example: /home/test space/liferay
2. Start the portal and go to Control Panel -> System Settings -> Foundation -> CXF Endpoints -> three dots -> Edit
3. Add a new configuration, setting as Context Path whatever value, for example "test" and save (ignore possible exceptions related to invalid context, they aren't relevant for the use case).
4. Stop the portal and with the upgrade tool upgrade to master.

 

Expected Results:

The upgrade should be able to finish without exceptions.

 

Actual Results:

The upgrade fails throwing the following exception:

2020-05-04 11:44:10.462 INFO  [main][ModuleFrameworkImpl:1533] Starting initial bundles
java.lang.RuntimeException: org.osgi.framework.BundleException: Exception in com.liferay.portal.configuration.persistence.internal.activator.ConfigurationPersistenceImplBundleActivator.start() of bundle com.liferay.portal.configuration.persistence.impl.
	at com.liferay.portal.util.InitUtil.initWithSpring(InitUtil.java:283)
	at com.liferay.portal.util.InitUtil.initWithSpring(InitUtil.java:199)
	at com.liferay.portal.tools.DBUpgrader.main(DBUpgrader.java:126)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.tools.db.upgrade.client.DBUpgraderLauncher.main(DBUpgraderLauncher.java:55)
Caused by: org.osgi.framework.BundleException: Exception in com.liferay.portal.configuration.persistence.internal.activator.ConfigurationPersistenceImplBundleActivator.start() of bundle com.liferay.portal.configuration.persistence.impl.
	at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:800)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:729)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:1002)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:354)
	at org.eclipse.osgi.container.Module.doStart(Module.java:581)
	at org.eclipse.osgi.container.Module.start(Module.java:449)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:428)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:447)
	at com.liferay.portal.bootstrap.ModuleFrameworkImpl._startConfigurationBundles(ModuleFrameworkImpl.java:1861)
	at com.liferay.portal.bootstrap.ModuleFrameworkImpl._setUpInitialBundles(ModuleFrameworkImpl.java:1749)
	at com.liferay.portal.bootstrap.ModuleFrameworkImpl.startFramework(ModuleFrameworkImpl.java:402)
	at com.liferay.portal.module.framework.ModuleFrameworkUtilAdapter.startFramework(ModuleFrameworkUtilAdapter.java:100)
	at com.liferay.portal.util.InitUtil.initWithSpring(InitUtil.java:230)
	... 7 more
Caused by: java.lang.IllegalArgumentException: Illegal character in path at index 14: file:/home/mal varo/dev/servers/dxp/osgi/configs/com.liferay.portal.remote.cxf.common.configuration.CXFEndpointPublisherConfiguration-dd271153-4b54-403f-8bc2-ff1b03288641.config
	at java.net.URI.create(URI.java:852)
	at com.liferay.portal.configuration.persistence.internal.ConfigurationPersistenceManager._verifyDictionary(ConfigurationPersistenceManager.java:493)
	at com.liferay.portal.configuration.persistence.internal.ConfigurationPersistenceManager.populateDictionaries(ConfigurationPersistenceManager.java:342)
	at com.liferay.portal.configuration.persistence.internal.ConfigurationPersistenceManager.start(ConfigurationPersistenceManager.java:186)
	at com.liferay.portal.configuration.persistence.internal.activator.ConfigurationPersistenceImplBundleActivator.start(ConfigurationPersistenceImplBundleActivator.java:62)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:779)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:772)
	... 19 more
Caused by: java.net.URISyntaxException: Illegal character in path at index 14: file:/home/mal varo/dev/servers/dxp/osgi/configs/com.liferay.portal.remote.cxf.common.configuration.CXFEndpointPublisherConfiguration-dd271153-4b54-403f-8bc2-ff1b03288641.config
	at java.net.URI$Parser.fail(URI.java:2848)
	at java.net.URI$Parser.checkChars(URI.java:3021)
	at java.net.URI$Parser.parseHierarchical(URI.java:3105)
	at java.net.URI$Parser.parse(URI.java:3053)
	at java.net.URI.<init>(URI.java:588)
	at java.net.URI.create(URI.java:850)
	... 27 more