Upgrade Fails Without Error When Store Set to AFS, no CFG file

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.2.1 CE GA2, Master
• Fix Version/s: 7.4.3.18 CE GA18, 7.4.3.27 CE GA27, 7.4.3.44 CE GA44, 7.4.3.45 CE GA45, Master
• Component/s: Database Upgrade Tool, Dynamic Data Mapping > Upgrades
• Labels:
  • fc_22_02
  • fc_22_03
  • fc_22_05
  • liferay-update-dxp-18-7413
  • pt-upgrade-review
• Fix Priority: 3
• Git Pull Request: https://github.com/SamZiemer/liferay-portal/pull/837
• Bug Type: Database Upgrade

During an upgrade from 6.2 to 7.2, the DB Upgrade Tool was run against a 6.2 Database. The upgrade tool itself ran to completion, without any errors, but starting the bundle in 7.2 resulted in having no portlets deployed.

Further investigation led to the discovery that the DDMServiceUpgrade was not registered as a result of the cfg file not being created in osgi/configs.

In discussions with alberto.chaparro, we believe the best path forward might be to just throw an error in the event that this happens again, so that it can more easily be addressed.

portal-ext.properties:

dl.store.impl=com.liferay.portal.store.file.system.AdvancedFileSystemStore

needed to be created: 

com.liferay.portal.store.file.system.configuration.AdvancedFileSystemStoreConfiguration.cfg

Steps to reproduce it:

1. Startup an old Liferay version with the advanced file system store configuration
2. Shutdown
3. Execute upgrade tool to upgrade to master with the dl.store.impl=com.liferay.portal.store.file.system.AdvancedFileSystemStore in portal-upgrade-ext.properties but remove the AdvancedFileSystemStoreConfiguration.cfg file

Expected results:
An exception saying "Store XXX is not available" is thrown

Current results:
No error is shown