Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-114879

Audit for transition end event listeners that may need emulation

    Details

      Description

      This is a followup to https://github.com/wincent/liferay-portal/pull/310 (LPS-109624) where we fixed a behavior that manifested when transition end events weren't being fired (for example, when an OS-level "prefers reduced motion" preference is in effect for accesibility reasons).

      If your code depends on the event firing for correct operation, then it will fail. If it merely degrades gracefully, then it's no big deal. In the case of that LPS, we just made sure that the code did the right thing by detecting a "prefers reduced motion" setting.

      As Patrick Yeo points out on the PR though, an alternative is also to make an abstraction that fakes transition end events in the event that the system doesn't trigger them. The proposal of this LPS is to do an audit of liferay-portal to see where we are listening to transition end events and determining:

      • Does the transition event merely have a cosmetic effect, or does it actually break things if suppressed?

      Based on the numbers of cosmetic and functional problems, we can decide whether to implement an abstraction and apply it everywhere, or not.

      cc Carlos Lancha

        Attachments

          Activity

            People

            Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            greg.hurrell Greg Hurrell (Inactive)
            Recent user:
            Greg Hurrell (Inactive)
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:

                Packages

                Version Package