addRole with role and multiple parameters behaves differently

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.2 CE GA3
• Fix Version/s: 7.2.10 DXP FP7, Master
• Component/s: Core Infrastructure, Core Infrastructure > Service Builder, User Management > Roles
• Labels:
  • liferay-fixpack-dxp-7-7210
  • pt-app-security-review
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/jhinkey/liferay-portal/pull/388

UserLocalService/UserLocalServiceUtil provides two methods to add a role:

Role addRole(long userId, String className, long classPK, String name, Map<Locale,String> titleMap, Map<Locale,String> descriptionMap, int type, String subtype, ServiceContext serviceContext)

and

addRole(Role role)

But these two methods behave differently.

addRole(role) just adds the role to the database, but the method with multiple parameters also calls resourceLocalService.addResources(...) and possible reindexes.

 

See:

https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portal/service/impl/RoleLocalServiceImpl.java#L172

Basically, it is an error to create a role using createRole + addRole(role), because then the resource is missing and you won't see the role in the control panel.