Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-117485

Gradle workspace conflict with DependencyManagementPlugin

    Details

      Description

      We have been using the following plugin since before it was included by liferay in its workspace

      io.spring.gradle.dependencymanagement.DependencyManagementPlugin

      Without never having issues. But recently if we set the following properties, we create a conflict and the build fails (as the workspace does not check the existence of the plugin, to test if it was already applied)

      liferay.workspace.target.platform.version=7.3.0

      Not a big issue, but with the new property liferay.workspace.product, it is hard not to notice the pollution created by warnings that could have been a bit less highlighted.

      The property `liferay.workspace.product` has not been set. It is recommended to set this property in gradle.properties in the workspace directory. See LPS-111700.

      This leads to `liferay.workspace.product` being required and liferay.workspace.target.platform.version=7.3.0 being buggy. Either way, we are now forced to use `liferay.workspace.product`to have clean logs, while liferay.workspace.target.platform.version stopped working with DependencyManagementPlugin being applied twice.


      *Issue: *

      • liferay.workspace.target.platform.version=7.3.0 not checking if the DependencyManagementPlugin is already applied (this is a really common plugin)
      • liferay.workspace.product being forced due to pollution in logs

      Expected

      • liferay.workspace.target.platform.version=7.3.0 being optional, as always, and checking for DependencyManagementPlugin
      • liferay.workspace.product being optional as well

      Reproduce

      1. Create a new workspace
      2. Apply io.spring.gradle:dependency-management-plugin
      3. Build - should work fine
      4. Use liferay.workspace.target.platform.version=7.3.0
      5. Build again to see the previously working project fail: +to fix, we need to know that this property will internally apply the same DependencyManagementPlugin
        +

        Attachments

          Activity

            People

            Assignee:
            gregory.amerson Gregory Amerson
            Reporter:
            victorlima02 Victor de Lima Soares
            Participants of an Issue:
            Recent user:
            Gregory Amerson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Days since last comment:
              23 weeks, 5 days ago

                Packages

                Version Package