Details
-
Technical Task
-
Status: Closed
-
Minor
-
Resolution: Completed
-
None
-
7.3.x, 7.2.x, 7.1.x, 7.0.x
-
Committed
-
Iteration 45, Iteration 46, Iteration 47, Iteration 48, Iteration 49, Iteration 50, AppSec Iteration 51, AppSec Iteration 52, AppSec Iteration 53, AppSec Iteration 54, AppSec Iteration 55, AppSec Iteration 56
Description
We have an entity named as MFAFIDO2CredentialEntry,
right now the service builder will generate variable names mfafido2CredentialEntry*,
while desired variable names would be mfaFIDO2CredentialEntry*
For example, in MFAFIDO2CredentialLocalServiceBaseImpl, there will be class member variable that can be inherited/used by MFAFIDO2CredentialLocalServiceImpl.
So when I try to use those class member variables from LocalServiceBaseImpl in LocalServiceImpl, it will look like:
MFAFIDO2CredentialEntry mfaFIDO2CredentialEntry = mfafido2CredentialEntryPersistence.fetchByUserId(userId);
@Override public MFAFIDO2CredentialEntry fetchMFAFIDO2CredentialEntryByCredentialId( String credentialId) { return mfafido2CredentialEntryPersistence.fetchByCredentialId( credentialId); }
Same thing for accessing variables from persistence layer.
Here is the diff change between without applying the fix and after applying the fix:
https://github.com/liferay/liferay-portal/pull/3939/commits/221c9de5d7c71101167a99a70a991a23cba753a9
Attachments
Issue Links
- is demanded by
-
LPS-120265 Prepare FIDO2 credential Service for FIDO2 checker
-
- Closed
-