Separator in Web Content Structures causes incrementation issues and loss of data on edit save

• Type: Bug
• Status: Verified
• Resolution: Unresolved
• Affects Version/s: 7.0.10.14 DXP SP14, 7.0.X, 7.1.10 DXP FP18, 7.1.X, 7.2.10 DXP FP5, 7.2.10 DXP FP7, 7.2.X, 7.3.4 CE GA5
• Fix Version/s: None
• Component/s: Dynamic Data Mapping
• Labels: None
• Fix Priority: 3
• Sprint: Data_Engine_7.4_09
• Git Pull Request: https://github.com/liferay-data-engine/liferay-portal-ee/pull/14

Description: Web Content Structure Builder fails to increment repeated field names inside a Separator Field on an edit. This causes loss of all edits on save. 

 

Steps to reproduce:

1. Content & Data > Web Content > Structures tab > Add new (blue plus)
2. Name your structure "Test title"
3. Drag and drop two separator fields
4. For each separator, drag and drop a text field inside
5. For each text field, change the FILED LABEL to the same value - "Test" - by double clicking on the field. ---> Notice that the NAME field is incremented - "Test" and "Test1"
6. Save the structure
7. Now open the structure again and add another Separator field
8. Add a Text field inside the separator
9. Name the Text field the same thing: "Test" --> Notice the field NAME is NOT incremented
10. Save the structure

 

 Expected Results: New text field NAME is incremented and saved OR an error is thrown with edits still present, allowing the user to fix them manually.

 Actual Results:  'Error: The definition field name Test was defined more than once.' is thrown and all modifications are lost. 

 

Notes:

• This behavior is repeatable with other field types, can mix and match.  
• I cannot replicate this behavior without the separator field.