Sidecar must not retry restart if failed to start at first attempt

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.X, Master
• Fix Version/s: 7.3.10 DXP FP1, 7.3.10.1 DXP SP1, 7.3.6 CE GA7, 7.3.X, 7.4.13 DXP GA1, Master
• Component/s: Search Infrastructure
• Labels:
  • 7.3-known-issues
  • 7.3-pre-fp1
  • liferay-dxp-73-sp1
  • liferay-fixpack-dxp-1-7310
  • liferay-ga6-ce-735
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Fix Priority: 4
• Epic Link: Elasticsearch 7 upgrade (Phase 3)
• Sprint: Search|S03Sprint 22|9.21-10.30, Search|S04Sprint 1|11.2-11.23
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/95760

Background

The restart feature is intended to quietly recover an ongoing healthy sidecar that was accidentally or unexpectedly shutdown for some reason. It is not intended for system startup to indefinitely retry a first launch under unhealthy and likely unrecoverable conditions.

Steps to reproduce

Start a regular Elasticsearch server, and then a Liferay with Sidecar, on the same port.

(Pick one: change Elasticsearch config to start on port 9201, or, change Sidecar settings to start on port 9200.)

Expected and observed: org.elasticsearch.bootstrap.StartupException: BindHttpException[Failed to bind to [::1]:9201]; nested: BindException[Address already in use];

Expected: Sidecar does not try again; Elasticsearch Connector fails to initialize.

Observed: Infinite retries of "Restarting sidecar Elasticsearch process".