Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-121255

DS checker Race condition registering Commerce when licensed

    XMLWordPrintable

Details

    • 3

    Description

      Race condition with the DS dependency checker and Commerce startup. No functional impact.

      Steps to Reproduce (Based on CI, not yet reproduced locally)

      1. Unzip Liferay DXP release bundle with Commerce
      2. Add Commerce and DXP xml licenses
      3. Import attached database to MySQL
      4. Navigate to tools/portal-tools-db-upgrade-client
      5. Run ./db_upgrade.sh
      6. After upgrade, start the DXP portal

      Expected Result:
      DXP always successfully starts and activates Commerce bundles with licensing.

      Actual Result:
      There is a race condition between the Commerce bundles registered by license file installation and main thread on starting portal.

      00:04:54,683 INFO  [fileinstall-directory-watcher][BundleStartStopLogger:46] STARTED com.liferay.commerce.tax.service_3.0.9 [1955]
00:04:57,270 WARN  [main][SystemCheckOSGiCommands:137] Declarative Service Unsatisfied Component Checker check result: 
Bundle {id: 1818, name: com.liferay.commerce.cart.taglib, version: 4.0.6}
	Declarative Service {id: 6689, name: com.liferay.commerce.cart.taglib.servlet.taglib.internal.servlet.ServletContextUtil, unsatisfied references: 
		{name: CommerceOrderItemService, target: null}
	}
Bundle {id: 1824, name: com.liferay.commerce.frontend.taglib, version: 10.0.13}
	Declarative Service {id: 6692, name: com.liferay.commerce.frontend.taglib.internal.servlet.ServletContextUtil, unsatisfied references: 
		{name: CPContentHelper, target: null}
		{name: CommerceOrderHttpHelper, target: null}
		{name: ProductHelper, target: null}
	}
Bundle {id: 1825, name: com.liferay.commerce.initializer.util, version: 6.0.9}
	Declarative Service {id: 6703, name: com.liferay.commerce.initializer.util.CommerceAccountsImporter, unsatisfied references: 
		{name: _commerceAddressLocalService, target: null}
		{name: _commerceCountryLocalService, target: null}
		{name: _commerceRegionLocalService, target: null}
	}
	Declarative Service {id: 6707, name: com.liferay.commerce.initializer.util.CommerceOrderImporter, unsatisfied references: 
		{name: _commerceContextFactory, target: null}
		{name: _commerceOrderItemLocalService, target: null}
		{name: _commerceOrderLocalService, target: null}
	}
	Declarative Service {id: 6719, name: com.liferay.commerce.initializer.util.internal.osgi.commands.CommerceOSGiCommands, unsatisfied references: 
		{name: _commerceOrderGenerator, target: null}
		{name: _commerceShipmentGenerator, target: null}
	}
	Declarative Service {id: 6699, name: com.liferay.commerce.initializer.util.CPDefinitionsImporter, unsatisfied references: 
		{name: _commerceAvailabilityEstimateLocalService, target: null}
		{name: _cpDefinitionInventoryLocalService, target: null}
		{name: _cpdAvailabilityEstimateLocalService, target: null}
	}
	Declarative Service {id: 6710, name: com.liferay.commerce.initializer.util.CommerceShipmentGenerator, unsatisfied references: 
		{name: _commerceOrderItemService, target: null}
		{name: _commerceOrderService, target: null}
		{name: _commerceShipmentItemLocalService, target: null}
		{name: _commerceShipmentLocalService, target: null}
	}
	Declarative Service {id: 6705, name: com.liferay.commerce.initializer.util.CommerceInventoryWarehousesImporter, unsatisfied references: 
		{name: _commerceCountryLocalService, target: null}
		{name: _commerceRegionLocalService, target: null}
	}
	Declarative Service {id: 6706, name: com.liferay.commerce.initializer.util.CommerceOrderGenerator, unsatisfied references: 
		{name: _commerceAddressLocalService, target: null}
		{name: _commerceContextFactory, target: null}
		{name: _commerceOrderEngine, target: null}
		{name: _commerceOrderItemLocalService, target: null}
		{name: _commerceOrderLocalService, target: null}
		{name: _commerceShippingMethodLocalService, target: null}
		{name: _cpDefinitionInventoryLocalService, target: null}
	}

      Workaround: Restarting the portal should resolve the issue.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. LPS-120419 Licensed apps are failing with "does not have a valid license"

          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LPS-121429 Its possible for a NPE to be thrown in SystemCheckOSGiCommands due to Commerce modules being activated randomly in startup with Licensing activation

          • Closed

          Activity

            People

              victor.ware Victor Ware
              victor.ware Victor Ware
              Kiyoshi Lee Kiyoshi Lee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                2 years, 15 weeks, 5 days ago

                Packages

                  Version Package
                  Master