Deprecate ElasticsearchConfiguration.syncSearch()

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Completed
• Affects Version/s: 7.0.X, 7.1.X
• Fix Version/s: 7.0.X, 7.1.X
• Component/s: Search Infrastructure
• Labels:
  • 7110-sp-pending
  • es7liferay71failedtest
  • fc_20_11
• Branch Version/s:
  7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Sprint: Search|S04Sprint 1|11.2-11.23, Search|S04Sprint 2|11.23-12.14
• Git Pull Request: https://github.com/liferay/liferay-portal-ee/pull/21746

The method ElasticsearchConfiguration.syncSearch() was removed in 7.2.x but to avoid major version bumps we add it back. It probably should be deprecated then, and have its documentation updated.

NOTE:
The ElasticsearchConfiguration.syncSearch() "behavior" in the ES6 connector was not affected by the ES7 backport to 7.1, so this issue probably doesnt need to be in the LPS-112200 (Elasticsearch 7 in DXP 7.1) epic.

Prior to this epic, ElasticsearchConfiguration.syncSearch() was not being used anywhere in the ES6 connector for Liferay 7.1. And actually all usages of ElasticsearchConfiguration.syncSearch() were removed in the original upgrade from ES2 to ES6. So the ES6 connector for Liferay 7.0 does not use syncSearch() either, even though the config is present there as well.