Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-122392

Remove {closest, contains, match} usages of metal-dom

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Completed
    • None
    • 7.4.13 DXP GA1, Master
    • Metal.js
    • None

    Description

      Part of our plan to Remove usages of metal-dom in DXP codebase.

      The goal of this task is to remove all usages of closest, contains and match from the metal-dom package.

      Initial analysis shows that these usages can be replaced by standard Apis like closest Apis or matches Apis.

      Acceptance Criteria

      • All usages of closest from metal-dom have been replaced
      • All usages of contains from metal-dom have been replaced
      • All usages of match from metal-dom have been replaced

      Additional Resources

      Posisble occurrences of closest (Deduped list of modules on git grep 'closest(' *.js*)

      • modules/apps/analytics/analytics-client-js
      • modules/apps/app-builder/app-builder-web
      • modules/apps/asset/asset-display-page-item-selector-web
      • modules/apps/asset/asset-publisher-web
      • modules/apps/commerce/commerce-frontend-js
      • modules/apps/commerce/commerce-frontend-taglib
      • modules/apps/commerce/commerce-product-options-web
      • modules/apps/commerce/commerce-theme-minium/commerce-theme-minium-impl
      • modules/apps/data-engine/data-engine-taglib
      • modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-builder
      • modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-field-type
      • modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-renderer
      • modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-report-web
      • modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-web
      • modules/apps/frontend-image-editor/frontend-image-editor-web
      • modules/apps/frontend-js/frontend-js-alert-support-web
      • modules/apps/frontend-js/frontend-js-aui-web
      • modules/apps/frontend-js/frontend-js-jquery-web
      • modules/apps/frontend-js/frontend-js-web
      • modules/apps/frontend-taglib/frontend-taglib-clay
      • modules/apps/frontend-taglib/frontend-taglib
      • modules/apps/item-selector/item-selector-web
      • modules/apps/journal/journal-web
      • modules/apps/layout/layout-admin-web
      • modules/apps/layout/layout-content-page-editor-web
      • modules/apps/portal-search/portal-search-web
      • modules/apps/product-navigation/product-navigation-product-menu-web
      • modules/apps/redirect/redirect-web
      • modules/apps/segments/segments-web
      • modules/apps/sharing/sharing-web
      • modules/apps/site-navigation/site-navigation-admin-web
      • modules/dxp/apps/saml/saml-web
      • portal-web/docroot/html/common/themes/bottom_js.jspf

      Posisble occurrences of contains (Deduped list of modules on git grep 'dom.contains(' *.js*)

      • modules/apps/app-builder/app-builder-web
      • modules/apps/data-engine/data-engine-taglib
      • modules/apps/frontend-js/frontend-js-spa-web

      Posisble occurrences of match (Deduped list of modules on git grep 'import {match}' *.js*)

      • modules/apps/frontend-js/frontend-js-spa-web
      • modules/apps/layout/layout-content-page-editor-web

      Attachments

        Activity

          People

            team-frontend-infrastructure Product Team Frontend Infrastructure
            jose.balsas Chema Balsas (Inactive)
            Diego Nascimento Diego Nascimento (Inactive)
            Kiyoshi Lee Kiyoshi Lee
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Packages

                Version Package
                7.4.13 DXP GA1
                Master