Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-116692 Add React Fragment generator to Fragments Toolkit
  3. LPS-123078

The react fragment with invalid codes shouldn't be imported via Fragments Toolkit

    Details

    • Type: Impedibug
    • Status: Closed
    • Priority: Major
    • Resolution: Discarded
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Fragments Toolkit
    • Labels:
      None

      Description

      Step to reproduce:

      1. Open command line
      2. yarn global add generator-liferay-fragments
      3. yo liferay-fragment
      4. Access to project directory
      5. yo liferay-fragment:fragment or yarn run add-fragment
      6. Type name
      7. Reply Y for Use React
      8. Choose a collection
      9. Access to src/${collectionName}/${reactFragment}
      10. Modify some codes from files to invalid
      11. Back to project directory
      12. yarn run import
      13. Assert the Import failure message is shown in command line
      14. Navigate to Fragments admin
      15. Assert the react fragment is not shown

      Expected Results:
      The import failure message should be shown in command line. Additionally, the react fragment should be shown in portal.

      Actual Results:
      The import failure message is not shown in command line. Additionally, the react fragment is shown as draft status in portal.

      Reproduced on:
      generator-liferay-fragments: 1.8.0-rc8
      yarn: 1.22.5
      Tomcat 9.0.37 + MySQL 5.7. Portal master GIT ID: 15335651c3de41fe6f2f9c131d152eb20f6ec5ec.

        Attachments

          Activity

            People

            Assignee:
            pablo.molina Pablo Molina
            Reporter:
            yang.cao Yang Cao
            Recent user:
            Pablo Molina
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package