Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-123391

Upgrade: Show a warning when a layout friendlyURL is not valid anymore

    Details

    • Fix Priority:
      2
    • Sprint:
      Upgrade|23.11-7.12|Bravas, Upgrade|14.12-28.12|Callos, Upgrade|4.1-18.1|CarneEnSarsa, Upgrade|1.18-2.1|CazónEnAdobo, Upgrade|2.1-2.15|Ensaladilla, Upgrade|2.17-3.3|Espeto, Upgrade|3.3-3.17|Gallinejas, Upgrade|3.17-3.31|Gazpacho

      Description

      Anytime we add a new layout friendly URL keyworks we need to warn users about the need of modifying the layout which is using that new value.

      Steps to reproduce:

      1. Startup 6.2
      2. Create a site page with /a as friendly url
      3. Upgrade to Master/7.3/7.2 and verify that everything went well
      4. Try to access that site

      Results:
      The upgrade log does not show any warning about the use of /a as friendlyURL and you can't access to that site page

      Expected results:
      The upgrade log shows a warning saying that you need to modify the friendlyURL because right now is a reserved keyword. You can't access to the site page anyways.

      Technical solution
      An option should be to create a new method in the VerifyProperties class which check if layouts exist with the new friendly URL keyword. We have to search by group and private layout since that's the unique index we need to use:
      create unique index IX_B556968F on Layout (groupId, privateLayout, friendlyURL[$COLUMN_LENGTH:255$], ctCollectionId);

      Apart from this, we can create a breaking change entry for the new reserved URLs (/a for example), a SF rule to require that would be helpful too.

        Attachments

          Activity

            People

            Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            alberto.chaparro Alberto Chaparro
            Participants of an Issue:
            Recent user:
            Marta Elicegui
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Days since last comment:
              44 weeks, 6 days ago

                Packages

                Version Package