RecentGroupManager class can parse too many recent groups

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.1.X, 7.2.X, 7.3.X, Master
• Fix Version/s: 7.2.10 DXP FP10, 7.2.10.4 DXP SP4, 7.2.X, 7.3.10 DXP FP1, 7.3.10.1 DXP SP1, 7.3.6 CE GA7, 7.3.X, 7.4.13 DXP GA1, Master
• Component/s: Navigation Menus, Site Settings
• Labels:
  • ee-ts
  • liferay-dxp-72-sp4
  • liferay-dxp-73-sp1
  • liferay-fixpack-dxp-1-7310
  • liferay-fixpack-dxp-10-7210
• Branch Version/s:
  7.3.x, 7.2.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-echo/liferay-portal/pull/2884

When navigating to certain areas of the portal where recent groups are used, the amount of time it takes to retrieve said groups can be very long depending on how many recent groups are available.  In one customer example, there were over 250 recent groups.  There is at least one DB fetch per recent group, and in some cases, only one recent group is needed to determine a boolean value.

Steps to reproduce:

1. Add the following portal-ext.properties: 
   • session.clicks.max.size.terms=20000
   • value.object.entity.cache.enabled=false
2. Run the CreateRecentGroups.groovyscript which creates 1000 groups and places them into your recent groups list.  This may take a few minutes.
3. Navigate to one of the newly created groups (this is only required if testing the solution with the script.  The solution will prevent many recent groups from being added, however the script bypasses this and forces 1000 groups into the list.)
4. Click on the compass icon to view recent sites

Expected results: Site navigation works quickly

Actual results: Site navigation takes some time, because all the recent groups are being re-validated per page refresh.

Reproduced in master: b50d81b60bf1437cc1418227d8d96eaefefce314