Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-123478

SAML version is incompatible with 7310 DXP GA1

    Details

    • Branch Version/s:
      7.3.x
    • Story Points:
      1
    • Fix Priority:
      4
    • Sprint:
      AppSec Iteration 55

      Description

      The version of portal-kernel is 9.8.0 when released DXP 7.3.10 GA1, But now it's 9.13.3. So if I change it to 9.8.0 in saml-impl and generated saml LPKG and deploy it to DXP 7.3.10 GA1, It will get the compile error like below.

         [exec] > Task :dxp:apps:saml:saml-api:deployConfigs NO-SOURCE
           [exec] /opt/dev/projects/github/liferay-portal-7.3.x/modules/dxp/apps/saml/saml-impl/src/main/java/com/liferay/saml/runtime/internal/servlet/filter/SamlSameSiteLaxCookiesFilter.java:20: error: package com.liferay.portal.kernel.resource.bundle does not exist
           [exec] import com.liferay.portal.kernel.resource.bundle.ResourceBundleLoader;
           [exec]                                                 ^
           [exec] /opt/dev/projects/github/liferay-portal-7.3.x/modules/dxp/apps/saml/saml-impl/src/main/java/com/liferay/saml/runtime/internal/servlet/filter/SamlSameSiteLaxCookiesFilter.java:172: error: cannot find symbol
           [exec] 	private volatile ResourceBundleLoader _resourceBundleLoader;
           [exec] 	                 ^
           [exec]   symbol:   class ResourceBundleLoader
           [exec]   location: class SamlSameSiteLaxCookiesFilter
           [exec] 2 errors
           [exec] 
           [exec] > Task :dxp:apps:saml:saml-impl:compileJava FAILED
      

      If I change to default(is 9.13.3) will compile successfully, but can't deploy to DXP 7.3.10 GA1, It will get dependency issue like this,
      And I found our changes about kernel is here.
      https://github.com/brianchandotcom/liferay-portal-ee/commit/c511093e3c4ffcb5cc842743c4d268142fb5ffee#diff-a97b063865d469727c798026e3c8de239249dbb83c992cde1146f60eaf0a5e57.
      So the SAML version is incompatible with 7310 DXP GA1.

        Attachments

        1. ds_unsatisfied.log
          0.5 kB
          Gábor Lovas
        2. saml_start.log
          6 kB
          Gábor Lovas

          Issue Links

            Activity

              People

              Assignee:
              gabor.lovas Gábor Lovas
              Reporter:
              della.wang Della Wang (Inactive)
              Participants of an Issue:
              Recent user:
              Brian Wulbern
              Engineering Assignee:
              Gábor Lovas
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                43 weeks, 2 days ago

                  Packages

                  Version Package
                  7.3.X