Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-123550

Turn off JS (and CSS) minifier by default

    Details

    • Type: Story
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: 7.4.13 DXP GA1, Master
    • Component/s: Minifier
    • Labels:
      None

      Description

      Based on the initial decision after Design of a new JS minification scheme in DXP, we will attempt to shift minification from run-time to build-time.

      Once this is completed and js (and css) resources are minified by default, the next step is to disable run-time minification. Most settings can be found in the #Minifier section of our default portal.properties which includes:

      • minifier.enabled
      • minifier.inline.content.cache.enabled
      • minifier.inline.content.cache.skip.css
      • minifier.inline.content.cache.skip.javascript

      The goal of this story is to disable run-time minification of resources by default.

      Acceptance Criteria

      • Minification is no longer enabled by default in production-like setup in portal.properties
      • A breaking change warning explains this change in behaviour and how to enable it back for those that need it.

      Additional Considerations

      • The minifier.enabled property enables both JS and CSS minification. For simplicity, since Simplify CSS minification scheme in DXP is in the short-term roadmap, we should be able to simply disable it now and make sure CSS minification doesn't depend on it before the release of 7.4 GA1

        Attachments

          Activity

            People

            Assignee:
            support-qa Support QA
            Reporter:
            jose.balsas Chema Balsas (Inactive)
            Recent user:
            Sophia Zhang
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                7.4.13 DXP GA1
                Master