Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-123933

For 7.3 Themes - package.json of theme generated for a custom theme has dev deps that are over 10 months old.

Details

    • 3
    • Regression Bug

    Description

      It looks like the package.json of a generated theme for 7.3 is coming in with outdated deps for _styled and _unstyled themes. The _unstyled theme in particular being so outdated is leading to missing lexicon icons, both the SVG files and missing icons from icons.svg.

       

      Found when looking for missing icon from custom theme:
      LPS-118583 "Change desktop viewport button icon"

       

       

      Was:

      "devDependencies": {"devDependencies": { 
      "compass-mixins": "0.12.10", 
      "gulp": "4.0.2", 
      "liferay-frontend-common-css": "1.0.4", 
      "liferay-frontend-theme-styled": "5.0.0", 
      "liferay-frontend-theme-unstyled": "5.0.0", 
      "liferay-theme-tasks": "^10.0.2", 
      "liferay-font-awesome": "3.4.0" },
      

      Should be higher than 5.0.0

      "devDependencies": {"devDependencies": { 
      "compass-mixins": "0.12.10", 
      "gulp": "4.0.2", 
      "liferay-frontend-common-css": "1.0.4", 
      "liferay-frontend-theme-styled": "5.0.16", 
      "liferay-frontend-theme-unstyled": "5.0.23", 
      "liferay-theme-tasks": "^10.0.2", 
      "liferay-font-awesome": "3.4.0" },
      

      Attachments

        Activity

          People

            kevin.wan Kevin Wan
            lee.jordan1 Lee Jordan
            Marta Elicegui Marta Elicegui
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              36 weeks, 6 days ago

              Packages

                Version Package
                7.3.X
                7.4.3.17 CE GA17
                Master