Details

      Description

      Allow picking a video hosted in liferay from the item selector.

      Embedding internal videos inside content does not work because the CKEditor injects a JS Player and the antisammy filters it. We discussed the 3 different approaches to fix this:

      1. Disable embedding of internal videos: Ruled out.
      2. Embed them as a simple html video element:
        • Pros:
          • Cleanest solution.
        • Cons:
          • We have to modify the existing JS plugins to support this case and to support the other cases (external videos)
          • We cannot embed a video that hasn’t been processed yet (which makes uploading directly from the item selector impossible).
      3. Embed them as a simple html video element:
        •  Pros:
          • We don’t need to modify any JS. All the existing code supporting external videos will work.
          • We control the rendering of the video in real time. This means we can display temporary messages while the video is being processed. This enables uploading directly from the item selector because we don’t need to wait for the video to be processed to embed it.
            We can potentially remove the old JS code that inserted the JS player since it is no longer used for this purpose.
        •  Cons:
          • We need to create a separate servlet to render the video tag. We did it and it works.

      We went for option 3.

       

      Acceptance criteria

      Given a site with videos uploaded to Liferay

      When a user plans to embed a video in a content

      Then the videos stored in Liferay are listed and selectable from the item selector

      Test Scenarios

      ID Test Priority Test Scenarios Covered by Backend (Unit/Integration)? Test to add
      2.46 5 An internal video can be selected via item selector when creating KB article with enabling Xuggler NO DLVideo#AddKBArticleWithEmbeddedVideo
      2.47 5 An internal video can be selected via item selector when creating Web Content with enabling Xuggler NO DLVideo#AddWCWithEmbeddedVideo
      2.48 5 An internal video can be selected via item selector when creating Blog with enabling Xuggler NO DLVideo#AddBlogEntryWithEmbeddedVideo
      2.49 4 An internal video is not listed via item selector with disabling Xuggler NO Manual
      2.50 4 An internal video in depot can be selected via item selector from the site once site is connected with enabling Xuggler NO DLVideo#AddWCWithEmbeddedVideo
      2.51 4 An internal video is not listed via item selector from the site once site is disconnected with enabling Xuggler NO Manual
      2.52 4 An edited internal video in depot can be republished on a connected staging site with enabling Xuggler NO DepotLocalStagingDM#EditInternalVideoInDepot and DepotRemoteStagingDM#EditInternalVideoInDepot

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              austin.chiang Austin Chiang
              Reporter:
              alejandro.tardin Alejandro Tardín
              Recent user:
              Sophia Zhang
              Participants of an Issue:
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  7.4.13 DXP GA1
                  Master