Clicking Sites tab in membership pop-up, displays sites with unchecked "Allow Manual Membership Management" confusing user

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.2.X, 7.3.X, Master
• Fix Version/s: 7.2.10 DXP FP10, 7.2.X, 7.3.X, Master
• Component/s: Site Memberships & Teams, Sites Administration > Sites
• Labels:
  • ee-ts
  • liferay-fixpack-dxp-10-7210
• Branch Version/s:
  7.3.x, 7.2.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-echo/liferay-portal/pull/3139

1. Navigate to Control Panel > Sites > Create New Site > Select Blank Site template > Name it "Site Membership"
2. Once created go on Site Menu > Configuration > Site Settings > Details Tab > Uncheck "Allow Manual Membership Management" option  > Save
3. Go back to Control Panel > Users and Organizations > Select current user > Go to Memberships tab > click "Select" button next to SITES tab
4. In the pop-up you should not see sites with uncheck "Allow Manual Membership Management" option, so "Site Membership" should not be displayed, for the first time this is correct
5. Now click on Sites tab in the pop-up, see "Site Membership" displayed for being selected (but the user can't select the site, so is confusing)

  Clicking on Sites tab in the pop-up,  should not display sites with uncheck "Allow Manual Membership Management" option

  Clicking on Sites tab in the pop-up,  displays sites with uncheck "Allow Manual Membership Management" option