Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-125130

Remove {Drag}, {DragDrop} usages of metal-drag-drop

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: Master
    • Component/s: Metal.js
    • Labels:
      None

      Description

      Part of our plan to remove usages of metal in DXP codebase

      The goal of this task is to remove existing usages of {Drag}, {DragDrop} from the metal-drag-drop package. 

      The intended order of removal is:

      1. Replace the classes/function calls with standard APIs or specific DXP functions when needed.
      2. Remove imports of these functions/objects in the .js files
      3. Remove the dependencies in package.json file if it's declared there

      Do not look for occurrences in neither .npmbundlerrc nor .eslintrc.js files as these will be dealt with in a separate task.

      For the case of {Drag} and {DragDrop} classes, the features offered may be substituted by some equivalent React library such as react-dnd. This is likely the right solution as the existing components which still use metal-drag-drop are also using metal-component, so those will be also substituted as part of this epic (see LPS-125125)

      Here is a list of usages

      Family Module File Usage
      dynamic-data-mapping dynamic-data-mapping-form-builder META-INF/resources/js/components/FormBuilder/withMoveableFields.es.js {DragDrop}
          META-INF/resources/js/components/FormBuilder/withResizeableColumns.es.js {Drag}
          META-INF/resources/js/components/Sidebar/Sidebar.es.js {Drag, DragDrop}
          package.json  
        dynamic-data-mapping-form-field-type package.json  
        dynamic-data-mapping-form-web package.json  
      frontend-js frontend-js-web package.json  
      layout layout-admin-web package.json  
      site-navigation site-navigation-admin-web package.json  

        Attachments

          Activity

            People

            Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            daniel.sanz Daniel Sanz
            Engineering Assignee:
            Krešimir Čoko
            Recent user:
            Greg Hurrell (Inactive)
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                Master