Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-125131

Remove {EventHandler}, {EventEmitter} and {EventEmitterProxy} usages of metal-events

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: Master
    • Component/s: Metal.js
    • Labels:
      None

      Description

      Part of our plan to remove usages of metal in DXP codebase

      The goal of this task is to remove existing usages of {EventHandler}, {EventEmitter} and {EventEmitterProxy} from the metal-events package. 

      The intended order of removal is:

      1. Replace the classes/function calls with standard APIs or specific DXP functions when needed.
      2. Remove imports of these functions/objects in the .js files
      3. Remove the dependencies in package.json file if it's declared there

      Do not look for occurrences in neither .npmbundlerrc nor .eslintrc.js files as these will be dealt with in a separate task.

      Here is a list of usages
       

      Family Module File Usage
      account account-admin-web META-INF/resources/account_entries_admin/js/AccountEntriesAdminPortlet.es.js EventHandler
          META-INF/resources/account_entries_admin/js/PersonAccountEntryEventHandler.es.js EventHandler
          package.json  
      dynamic-data-mapping dynamic-data-mapping-form-builder META-INF/resources/js/components/FormBuilder/FieldActionsDropDown.es.js EventHandler
          META-INF/resources/js/components/FormBuilder/withActionableFields.es.js EventHandler
          META-INF/resources/js/components/FormBuilder/withClickableFields.es.js EventHandler
          META-INF/resources/js/components/Sidebar/Sidebar.es.js EventHandler
          package.json  
        dynamic-data-mapping-form-web META-INF/resources/admin/js/main.es.js EventHandler
          META-INF/resources/admin/js/components/ShareFormModal/ShareFormModal.es.js EventHandler
          META-INF/resources/admin/js/util/StateSyncronizer.es.js EventHandler
          package.json  
      frontend-js frontend-js-web META-INF/resources/liferay/DynamicInlineScroll.es.js EventHandler
          META-INF/resources/liferay/side_navigation.es.js EventEmitter
          test/liferay/CompatibilityEventProxy.es.js EventEmitter
          package.json  
          META-INF/resources/management_toolbar/ManagementToolbar.es.js EventEmitterProxy
          package.json  
      item-selector item-selector-taglib META-INF/resources/repository_entry_browser/js/ItemSelectorRepositoryEntryBrowser.es.js EventHandler
          package.json  
      journal journal-web META-INF/resources/js/JournalPortlet.es.js EventHandler
      layout layout-admin-web package.json  
        layout-content-page-editor-web META-INF/resources/page_editor/common/components/Editor.js EventHandler
          package.json  
      message-boards message-boards-web package.json  
      product-navigation product-navigation-product-menu-web package.json  
      users-admin users-admin-web META-INF/resources/js/UserNameFields.es.js EventHandler
          package.json  
      wiki wiki-web package.json  

        Attachments

          Activity

            People

            Assignee:
            brian.chan Brian Chan
            Reporter:
            daniel.sanz Daniel Sanz
            Engineering Assignee:
            Krešimir Čoko
            Recent user:
            Brian Chan
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                Master