Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: 7.4.13 DXP GA1, Master
    • Component/s: Minifier
    • Labels:
      None

      Description

      As per our analysis

      Suggested action:

        • Either do nothing, or hand-minify (in which case we'd need to add a Java SF suppression because it will complain about any such changes we make to this file). I'm lightly inclined to probably do the latter in order to prevent Lighthouse (and other tools) from reporting it as something that could be minified. Disclaimer: even with hand minification, we can expect some whitespace damage simply from using JSP in the first place (see example output above).-
      • As per comment thread, we can inline this in top_js.jspf, avoiding an unnecessary request and at least keeping all the config-ish JS together.
      • Rationale:
        • Even if we turned on minification in JSP, it wouldn't help us here because this JSP file contains no <script> tag; it's just raw JS in a file.-
      • Expected cost: < 1 day (including time to prepare PR, test it, get it through CI, forward it).

        Attachments

          Activity

            People

            Assignee:
            brian.chan Brian Chan
            Reporter:
            jose.balsas Chema Balsas (Inactive)
            Engineering Assignee:
            SE Support
            Recent user:
            Sophia Zhang
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                7.4.13 DXP GA1
                Master