Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-126202

AlloyEditor source tab no longer respects line breaks.

    Details

      Description

      After upgrading from 7.2 Fix Pack 8 to Fix Pack 9, the AlloyEditor "Source" tab no longer formats the markup.

      Reproduction steps:
      1) Get 7.2 DXP vanilla and patch it with Fix Pack 9, start the server and login as an Admin
      2) Go to left Sidebar > Liferay DXP > Content and add a new Basic Web Content
      3) Enter some text and a table with some text inside the cells
      4) Switch to source tab and check the markup:

      Expected:

      <p>Hello World</p>
      
      <table border="1" cellpadding="0" cellspacing="0" style="width: 100%">
       <tbody>
        <tr>
            <td>one</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>two</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>three</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
       </tbody>
      </table>
      

      Actual behavior:

      <p>Hello World</p><table border="1" cellpadding="0" cellspacing="0" style="table-layout: fixed; width: 100%;"><tbody><tr><td>one</td><td> </td><td> </td></tr><tr><td>two</td><td> </td><td> </td></tr><tr><td>three</td><td> </td><td> </td></tr></tbody></table><p> </p>

      Not reproduced on Fix Pack 8
      Reproduced on Fix Pack 9
      Reproduced on 7.2.x @ 1ceb01053a6e237a5da97a9df66ddd7f48d645dc327cd143cff37fbdff1d7eef
      Reproduced on master @ 9834c0f6b760efefb61ff2b359ca171f0e43d7df2e17a42889426e1102b3cb22

      on master Alloyeditor is not the default editor anymore, we have to change the portal-ext.properties

          editor.wysiwyg.portal-web.docroot.html.portlet.blogs.edit_entry.jsp=alloyeditor
      

      With this you can reproduce it within blogs, by creating a new blog entry and follow the steps fro step3

      This issue was introduced with LPS-121241 on 7.2, looks like the ckeditor version bump broke our AE source editor.
      We are not getting the line breaks when we retrieve the value from the editor within alloyeditor_source.js

      * Please see Zendesk Support tab for further comments and attachments.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              team-frontend-infra Product Team Frontend Infrastructure
              Reporter:
              norbert.nemeth Norbert Németh
              Participants of an Issue:
              Recent user:
              Minhchau Dang
              Engineering Assignee:
              Norbert Németh
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                13 weeks, 3 days ago

                  Packages

                  Version Package
                  7.2.X
                  7.3.X
                  7.4.0 CE GA1
                  Master