Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-127258

Source formatter renamed protected variable causes NullPointerException

Details

    Description

      Multiple places, the protected variable was renamed from request to httpServletRequest, and then request (which was retained but deprecated) was left null.

      This is a breaking change that affects all child classes which extend the class, and so we should make sure to also set the original deprecated variable in all branches other than master.

      Steps to reproduce

      1. Build the original fix-pack-base-7310 tag
      2. Build the latest 7.3.x
      3. Copy the com.liferay.marketplace.app.manager.web.jar from the built fix-pack-base-7310 tag into your 7.3.x bundle
      4. Start up Liferay and observe there are no bundle resolution errors
      5. Go to Control Panel > App manager

       Actual Result:
      App manager is not displayed

       Expected Result:
      App manager is displayed

      Attachments

        Issue Links

          Activity

            People

              brian.chan Brian Chan
              minhchau.dang Minhchau Dang
              Marta Elicegui Marta Elicegui
              Minhchau Dang Minhchau Dang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1 year, 41 weeks, 5 days ago

                Packages

                  Version Package
                  7.3.10 DXP FP1
                  7.3.10.1 DXP SP1
                  7.3.6 CE GA7
                  7.3.X