REST Builder generated clients can not deserialize BigDecimals

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.0.0 DXP FP98, 7.0.X, 7.1.10 DXP FP22, 7.1.X, 7.2.10 DXP FP11, 7.2.10.4 DXP SP4, 7.2.X, 7.3.10 DXP FP1, 7.3.10.1 DXP SP1, 7.3.6 CE GA7, 7.3.X, 7.4.13 DXP GA1, Master
• Component/s: REST Builder
• Labels:
  • liferay-dxp-72-sp4
  • liferay-dxp-73-sp1
  • liferay-fixpack-de-98-7010
  • liferay-fixpack-dxp-1-7310
  • liferay-fixpack-dxp-11-7210
  • liferay-fixpack-dxp-22-7110
• Branch Version/s:
  7.3.x, 7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 2
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/99049

Steps to reproduce:

• Use a rest client module generated by REST Builder, for example enabling Commerce Orders integration tests

Expected result:

Integration tests complete successfully

Actual result:

Tests fail with with misleading errors:

com.liferay.headless.commerce.admin.order.resource.v1_0.test.OrderResourceTest > testGetOrderWithNestedEntities FAILED
    java.lang.IllegalArgumentException: Unsupported field name accountExternalReferenceCode
    	at com.liferay.headless.commerce.admin.order.client.problem.Problem$ProblemJSONParser.setField(Problem.java:178)
    	at com.liferay.headless.commerce.admin.order.client.problem.Problem$ProblemJSONParser.setField(Problem.java:140)
    	at com.liferay.headless.commerce.admin.order.client.json.BaseJSONParser.parseToDTO(BaseJSONParser.java:90)
    	at com.liferay.headless.commerce.admin.order.client.problem.Problem.toDTO(Problem.java:33)
    	at com.liferay.headless.commerce.admin.order.client.resource.v1_0.OrderResource$OrderResourceImpl.getOrder(OrderResource.java:676) 

Debugging it show a ClassCastException when deserializing Strings to BigDecimals