FacetedSearcherTest is flaky

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, 7.3.X, Master
• Fix Version/s: 7.3.10 DXP FP1, 7.3.10.1 DXP SP1, 7.3.6 CE GA7, 7.3.7 CE GA8, 7.3.X, 7.4.0 CE GA1, 7.4.13 DXP GA1, Master
• Component/s: Search Infrastructure
• Labels:
  • backend_test
  • backend_test_fix
  • liferay-dxp-73-sp1
  • liferay-fixpack-dxp-1-7310
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-search/liferay-portal/pull/94

Attached is an error that FacetedSearcherTest can produce. Because the search prefix is a random string it can find other documents in search. In this particular flake, it's finding the Hello World welcome page and fails when checking if all results are users.

To test I had to modify the test.
Steps to Reproduce:

1. Modify the testSearchByKeywordsIgnoresInactiveSites test by setting prefix = "WiQp7C5C"
2. Log on to the portal and make sure the 7.4 welcome page is present, if it isn't add the Hello World widget to a content page.
3. Run the FacetedSearcherTest.testSearchByKeywordsIgnoresInactiveSites integration test.

Expected Result: Test passes.
Actual Result: Test fails because the search returns the Hello World welcome page along with Users.