Details

      Description

      In Provide Modal Patterns matching Lexicon Definition, we provided updated Modal Patterns in DXP to match Lexicon's recommendations and applied them as globally as possible.

      Some usages couldn't be updated in time and some others weren't in our codebase at the time (commerce).

      The goal of this epic is to complete the migration to the openModal APIs created in Provide Modal Patterns matching Lexicon Definition and deprecate all unnecessary components and modules to ensure UX consistency.

      Modal APIs Usages

       

      Acceptance Criteria:

      Test Information section

       

      Test Scenarios:

      Requirement Test Case Covered by frontend/backend unit test? (Yes/No) Test Priority (business impact) Pass/Fail
      There are no usages of ItemSelectorDialog Given console terminal at liferay portal root
      When run command:
      git grep 'new ItemSelectorDialog' -- '*'

      Then returns no lines except from commerce-account-*, archived, etc.
      Note: openItemSelectorDialog uses itemSelectorDialog. So as long as itemSelectorDialog is replaced then openItemSelectorDialog may still make sense to exist

      no 5-critical  
      There are no usages of A.LiferayItemSelectorDialog Given console terminal at liferay portal root
      When run command:
      git grep 'new A.LiferayItemSelectorDialog' -- '*'

      Then returns no lines except from commerce-account-*, archived, etc.

      no 4-major  
      There are no usages of Liferay.Util.selectEntity Given console terminal at liferay portal root *
      When run command:
      git grep 'Liferay.Util.selectEntity(' -- '*'

      Then returns no lines except from commerce-account-*, archived, etc.

      no 5-critical  
      There are no usages of Liferay.Util.selectEntityHandler Given console terminal at liferay portal root *
      When run command:
      git grep 'Liferay.Util.selectEntityHandler(' -- '*'

      Then returns no lines except from commerce-account-*, archived, etc.

      no 4-major  
      ItemSelectorDialog is deprecated Given console terminal at liferay portal root
      When run command:
      git grep -W @deprecated -- 'ItemSelectorDialog.es.js'

      Then returns @deprecated above this initialization line: class ItemSelectorDialog extends Component {

      no 3-medium  
      Liferay.Util.selectEntity is deprecated Given console terminal at liferay portal root
      When run command:
      git grep -A 3 -B 10 selectEntity – '*frontend-js-aui-web/*/liferay/util.js'

      Then returns @deprecated above the Liferay.provide function using selectEntity

      no 3-medium  
      Liferay.Util.selectEntityHandler is deprecated Given console terminal at liferay portal root
      When run command:
      git grep -A 3 -B 10 selectEntityHandler -- '*frontend-js-aui-web/*/liferay/util.js'

      Then returns @deprecated above the Liferay.provide function using selectEntityHandler

      no 3-medium  

      Exploratory Scenarios:

      Requirement Test Case Test Priority (business impact) Chrome
      Pass/Fail
      Firefox
      Pass/Fail
      Edge
      Pass/Fail
      Safari
      Pass/Fail
        Exploratory Test: check a couple impacted modals are still working ok and follows Lexicon patterns
      Example:
      Area impacted by new ItemSelectorDialog usage removal -
      Documents & Media > open a document > Edit > Categorization > Select Vocabulary / Store / Topic
      4-major        
        Exploratory API testing 3-medium    n/a   n/a   n/a
        Exploratory API testing, to see if API messages provide useful errors 3-medium     n/a   n/a   n/a
        Exploratory test if can easily send/receive heavy state objects with new API. 3-medium     n/a   n/a   n/a

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              jose.balsas Chema Balsas (Inactive)
              Recent user:
              Bruno Fernández
              Participants of an Issue:
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package