Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-129990

Ensure generated taglib files are NEVER manually modified

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Dev Tools
    • Labels:
      None

      Description

      Go to modules/apps/dynamic-data-mapping/dynamic-data-mapping-taglib

      Type

      git grep '@generated'

      src/main/java/com/liferay/dynamic/data/mapping/taglib/servlet/taglib/base/BaseHTMLFieldTag.java: * @generated
      src/main/java/com/liferay/dynamic/data/mapping/taglib/servlet/taglib/base/BaseHTMLTag.java: * @generated
      src/main/java/com/liferay/dynamic/data/mapping/taglib/servlet/taglib/base/BaseTemplateRendererTag.java: * @generated
      src/main/java/com/liferay/dynamic/data/mapping/taglib/servlet/taglib/base/BaseTemplateSelectorTag.java: * @generated
      src/main/resources/META-INF/resources/html/init.jsp:@generated
      src/main/resources/META-INF/resources/html_field/init.jsp:@generated
      src/main/resources/META-INF/resources/init.jsp:@generated
      src/main/resources/META-INF/resources/template_renderer/init.jsp:@generated
      src/main/resources/META-INF/resources/template_selector/init.jsp:@generated

      Delete those files

      Run 'gradlew buildTaglib'

      There should be no changes.

      We need a CI test for this similar to how we ensure that ServiceBuilder changes are never made to generated files.

      The CI test will currently break because of LPS-129989, but I still want the CI test added so we can turn it on as soon as we fix it. I also want to know which other taglib modules are broken.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peter.shin Peter Shin
              Reporter:
              brian.chan Brian Chan
              Recent user:
              Brian Chan
              Participants of an Issue:
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package