-
Type:
Bug
-
Status: Closed
-
Resolution: Fixed
-
Affects Version/s: Master
-
Fix Version/s: 7.4.1 CE GA2, 7.4.13 DXP GA1, Master
-
Component/s: Tag Libraries > Clay Taglibs
-
Labels:
-
Fix Priority:4
-
Sprint:S04E14 - Una Mattina, S04E15 - Kind of Blue
-
Git Pull Request:
In the latest version (tried latest 7.3 ga) the clay button taglib added a type="button" by default if no type was provided, but now in master this is no longer true. This is a breaking change
Steps to reproduce:
- Remove this line: https://github.com/liferay/liferay-portal/blob/7b685ec5a296582b7052d81fc5d90481a116fc33/modules/apps/journal/journal-web/src/main/resources/META-INF/resources/article/template.jsp#L45
- deploy journal-web
- Go to web content
- Create a web content, give it a title and publish
- Edit again go to the sidebar -> default template section
- Inspect the preview button (the one with an eye)
Actual result
type="button" is not added
Expected result
type="button" should be added as before