Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-130629

clay:button is not adding type="button" as before

    Details

      Description

      In the latest version (tried latest 7.3 ga) the clay button taglib added a type="button" by default if no type was provided, but now in master this is no longer true. This is a breaking change

       

      Steps to reproduce:

      1. Remove this line: https://github.com/liferay/liferay-portal/blob/7b685ec5a296582b7052d81fc5d90481a116fc33/modules/apps/journal/journal-web/src/main/resources/META-INF/resources/article/template.jsp#L45
      2. deploy journal-web
      3. Go to web content 
      4. Create a web content, give it a title and publish
      5. Edit again go to the sidebar -> default template section
      6. Inspect the preview button (the one with an eye)

      Actual result

      type="button" is not added

      Expected result

      type="button" should be added as before

       

        Attachments

          Activity

            People

            Assignee:
            team-frontend-infra Product Team Frontend Infrastructure
            Reporter:
            victor.galan Victor Galan
            Participants of an Issue:
            Recent user:
            Rafaela Nascimento
            Engineering Assignee:
            Marko Čikoš
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Days since last comment:
              21 weeks, 6 days ago

                Packages

                Version Package
                7.4.1 CE GA2 DXP 7,4
                Master