Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-131903

Users can attempt to edit page when propagated site page is locked

    Details

      Description

      This ticket has already been committed by a different team, but is similar to LPS-132256.  Since the code changes are being handled by two different teams and committed at different times, this ticket has been re-scoped to only include relevant details.  See LPS-132256 for the "other half" of the bug.

      Description:

      When viewing a site page which has been propagated from a site template, if the "Allow site administrators to modify this page for their site, even when propagation of changes is enabled." option is disabled, the user can still attempt to edit the page.  The user can also attempt to modify the portlet permissions in the view page.

      These are visual bugs only since nothing can be modified once the layout is locked.  However, these options are unnecessary and can lead to confusion.

      Steps to reproduce:

      1. Control Panel > Sites > Site Templates
      2. Make a new template, unchecking the "Allow site administrators to modify pages associated with this site template, even when propagation of changes is enabled."
      3. Control Panel > Sites > Sites
      4. Make a new site based off the template
      5. Click "Home" to view the site's home page
      6. Verify there is an "i" icon in the upper-right toolbar which reads "This page is linked to a site template which does not allow modifications to it."
      7. Hover over the Site Navigation portlet and click the options.
      8. Verify "Permissions" is available and can be selected
      9. Verify there is a pencil icon in the upper-right toolbar which when clicked, brings the user to the edit page

      Expected results: The user does not see the pencil icon nor the portlet permissions options since the page is linked to a site template which does not allow for modifications

      Actual results: The user can click the pencil icon, entering the edit page and they can attempt to modify the portlet permissions

      Reproduced in master: 5e223c8b9f0215cb982ccf36e1fcf32db9ad262a

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              joyce.wang Joyce Wang
              Reporter:
              christopher.kian Christopher Kian
              Participants of an Issue:
              Recent user:
              Tamas Molnar
              Engineering Assignee:
              Christopher Kian
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                18 weeks, 2 days ago

                  Packages

                  Version Package
                  7.2.10 DXP FP14
                  7.2.10.5 DXP SP5
                  7.2.X
                  7.3.7 CE GA8
                  7.3.10 DXP FP2
                  7.3.X
                  7.4.1 CE GA2 DXP 7,4
                  Master