OPTION requests trigger exceptions in JSResolveModulesServlet

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.X, Master
• Fix Version/s: 7.3.7 CE GA8, 7.3.10 DXP FP2, 7.3.X, 7.4.1 CE GA2, 7.4.2 CE GA3, 7.4.13 DXP GA1, Master
• Component/s: Tag Libraries > Liferay Frontend Taglibs
• Labels:
  • ee-ts
  • liferay-fixpack-dxp-2-7310
  • liferay-ga3-ce-742
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-frontend/liferay-portal/pull/1138

Steps to reproduce:

1. Start a 7.3.10-dxp-1 bundle 
2.  Use curl to simulate an option request (install curl and on a separate console use the following command while the portal is running):

curl -X OPTIONS "http://localhost:8080/o/js_resolve_modules?modules=frontend-js-alert-support-web%401.0.7%2Findex"

1. Check the portal console

Expected behavior:

There won't be any errors in the log

Actual behavior:

java.lang.StringIndexOutOfBoundsException: String index out of range: -8 is thrown

 

Notes: The Baidu search engine sends OPTION requests to the servers before accessing urls, this issue can fill up the logs quite easily eventho the error itself is harmless

Reproduced on:

  7.3.10-dxp-1

  7.3.x @ af78f4e5ec6947bf8d5277834a9c031285cfdc2708564204cd9dc676f8d03d96

  master @ f2f04c1d2d5934e9bcd79ea7ca91bed9d68b678309e8d4efaf6795321f4f8ef9