Journal Service upgrade occasionally fails with UndeployedExternalRepositoryException

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.X, Master
• Fix Version/s: 7.3.10.3 DXP SP3, 7.3.X, 7.4.1 CE GA2, 7.4.13 DXP GA1, Master
• Component/s: Document Repository Framework, Web Content > Web Content Administration
• Labels:
  • ee-ts
  • liferay-dxp-73-sp3
  • liferay-fix-pack-dxp-3-7310
  • liferay-fixpack-dxp-3-7310
  • liferay-ga3-ce-742
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Story Points: 1
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-lima/liferay-portal/pull/1914
• QA Test Name:
  • dont-test-again

The upgrade for Journal Service can fail with an UndeployedExternalRepositoryException due to OSGi modules being registered in the wrong order. If the "Liferay Document Library Repository Portlet Repository Implementation" module has not yet been registered by the time the Journal Service upgrade proceeds, then it can result in the UndeployedExternalRepositoryException. This is because the Journal Service upgrade calls this code to add a repository. That code attempts to look up the PortletRepository class. If the "Liferay Document Library Repository Portlet Repository Implementation" module has not yet been registered, then the lookup will fail with an UndeployedExternalRepositoryException, since that module holds the class responsible for registering the PortletRepository class.

We should add a dependency from the "Liferay Document Library Repository Portlet File Repository Implementation" module onto the "Liferay Document Library Repository Portlet Repository Implementation" module to ensure that this cannot happen.

Steps to Reproduce
Unfortunately, as this is a timing issue, the issue cannot be consistently reproduced. It can happen occasionally when upgrading from Liferay 7.0 to Liferay 7.3.