Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-133955

com.liferay.portal.upgrade.v7_0_0.UpgradeLookAndFeel fails when portletSetupShowBorders is read-only

    Details

      Description

      Issue was first raised here: https://liferay.slack.com/archives/CUQP9C673/p1622748287072600.

      Description:
      When a user upgrades from 6.2 to a later DXP version, the com.liferay.portal.upgrade.v7_0_0.UpgradeLookAndFeel upgrade process produces a javax.portlet.ReadOnlyException and fails whenever the preference portletSetupShowBorders is set to read-only:

      2021-05-25 20:16:59.936 INFO [main][UpgradeProcess:115] Failed upgrade process com.liferay.portal.upgrade.v7_0_0.UpgradeLookAndFeel in 5192 ms
      2021-05-25 20:16:59.936 INFO [main][UpgradeProcess:115] Failed upgrade process com.liferay.portal.upgrade.UpgradeProcess_7_0_0 in 168414 ms
      com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.kernel.upgrade.UpgradeException: javax.portlet.ReadOnlyException: portletSetupShowBorders
      at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:109)
      at com.liferay.portal.kernel.upgrade.util.UpgradeProcessUtil._upgradeProcess(UpgradeProcessUtil.java:172)
      at com.liferay.portal.kernel.upgrade.util.UpgradeProcessUtil.upgradeProcess(UpgradeProcessUtil.java:135)
      at com.liferay.portal.events.StartupHelperUtil.upgradeProcess(StartupHelperUtil.java:182)
      at com.liferay.portal.tools.DBUpgrader._upgradePortal(DBUpgrader.java:334)
      at com.liferay.portal.tools.DBUpgrader.upgrade(DBUpgrader.java:151)
      at com.liferay.portal.tools.DBUpgrader.upgrade(DBUpgrader.java:143)
      at com.liferay.portal.tools.DBUpgrader.main(DBUpgrader.java:123)
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.base/java.lang.reflect.Method.invoke(Method.java:566)
      at com.liferay.portal.tools.db.upgrade.client.DBUpgraderLauncher.main(DBUpgraderLauncher.java:54)
      Caused by: com.liferay.portal.kernel.upgrade.UpgradeException: javax.portlet.ReadOnlyException: portletSetupShowBorders
      at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:109)
      at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:131)
      at com.liferay.portal.upgrade.UpgradeProcess_7_0_0.doUpgrade(UpgradeProcess_7_0_0.java:97)
      at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:104)
      ... 12 more
      Caused by: javax.portlet.ReadOnlyException: portletSetupShowBorders
      at com.liferay.portlet.PortletPreferencesImpl.reset(PortletPreferencesImpl.java:120)
      at com.liferay.portal.upgrade.v7_0_0.UpgradeLookAndFeel.upgradePreferences(UpgradeLookAndFeel.java:51)
      at com.liferay.portal.kernel.upgrade.BaseUpgradePortletPreferences.updatePortletPreferences(BaseUpgradePortletPreferences.java:247)
      at com.liferay.portal.kernel.upgrade.BaseUpgradePortletPreferences.doUpgrade(BaseUpgradePortletPreferences.java:39)
      at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:104)
      ... 15 more
      

      This shouldn't be an issue that stops the upgrade process from completing and should be handled properly.

      Steps to Reproduce:

      1. import 6.2 database dump: pre-upgrade.sql.
      2. Set up Liferay DXP.
      3. Run the upgrade.

      Actual Result:
      The upgrade fails with javax.portlet.ReadOnlyException: portletSetupShowBorders.

      Expected Result:
      The upgrade process completes with no errors.

      Reproducible on:

      • master (a0de1166dd81ef9c)
      • 7.3.x (35cae9d2afcbf9a8)
      • 7.2.x (380ce6aa304d0eaf)
      • 7.1.x (385fa87d3e170cd33)
      • 7.0.x (3ec06eef7f7fa37d)

        Attachments

          Activity

            People

            Assignee:
            summer.zhang Summer Zhang
            Reporter:
            kevin.lee Kevin Lee
            Participants of an Issue:
            Recent user:
            Rafaela Nascimento
            Engineering Assignee:
            Kevin Lee
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Days since last comment:
              12 weeks, 1 day ago

                Packages

                Version Package
                7.3.X
                7.4.2 CE GA3 DXP 7,4
                Master