BasePersistenceImpl.fetchByPrimaryKeys does not honor database.in.max.parameters

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.2.X, 7.3.X, Master
• Fix Version/s: 7.2.10 DXP FP15, 7.2.X, 7.3.10.3 DXP SP3, 7.3.X, 7.4.2 CE GA3, 7.4.13 DXP GA1, 7.4.3.4 CE GA4, Master
• Component/s: Performance > Caching Infrastructure
• Labels:
  • INACTIVE
  • backend_test
  • ee-ts
  • liferay-dxp-73-sp3
  • liferay-fix-pack-dxp-3-7310
  • liferay-fixpack-dxp-15-7210
  • liferay-fixpack-dxp-3-7310
  • pt-upgrade-review
• Branch Version/s:
  7.3.x, 7.2.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/shuyangzhou/liferay-portal/pull/10140

Steps to reproduce

1. Start up Liferay pointing to an Oracle database
2. Run the following Groovy script to create 1200 AnnouncementsFlag entries (it's a small table so it should finish quickly)

   import com.liferay.announcements.kernel.service.AnnouncementsFlagLocalService
   import com.liferay.registry.RegistryUtil
   
   def registry = RegistryUtil.getRegistry()
   def announcementsFlagLocalService = registry.getServices(AnnouncementsFlagLocalService.class, null)[0]
   
   if (announcementsFlagLocalService.getAnnouncementsFlagsCount() < 1200) {
   	for (int i = 0; i < 1200; i++) {
   		announcementsFlagLocalService.addFlag(0, i, 0)
   	}
   }
   

3. Run the following Groovy script, which fetches the 1200 AnnouncementsFlag entries, clears the entity cache, and then re-fetches them again

   import com.liferay.portal.kernel.dao.orm.EntityCacheUtil
   import com.liferay.portal.kernel.dao.orm.FinderCacheUtil
   import com.liferay.announcements.kernel.service.AnnouncementsFlagLocalService
   import com.liferay.registry.RegistryUtil
   
   def registry = RegistryUtil.getRegistry()
   def announcementsFlagLocalService = registry.getServices(AnnouncementsFlagLocalService.class, null)[0]
   
   FinderCacheUtil.clearCache()
   
   out.println("finding results (finder cache miss)")
   
   try {
   	out.println("find attempt succeeded: " + announcementsFlagLocalService.getAnnouncementsFlags(-1, -1).size())
   }
   catch (Exception e) {
   	e.printStackTrace(out)
   }
   
   out.println("finding results (finder cache hit)")
   
   EntityCacheUtil.clearCache()
   
   try {
   	out.println("find attempt succeeded: " + announcementsFlagLocalService.getAnnouncementsFlags(-1, -1).size())
   }
   catch (Exception e) {
   	e.printStackTrace(out)
   }
   

Expected behavior: The second Groovy script runs without errors
Actual behavior: The second Groovy script is able to successfully fetch prior to clearing the entity cache, but prints a stack trace after clearing the entity cache