Details
-
Bug
-
Status: Closed
-
Resolution: Fixed
-
7.2.X, 7.3.X, Master
-
7.3.x, 7.2.x
-
Committed
-
3
-
Accessibility
Description
Description: We have a client that is using this tool to verify the validity of their website (I explained more about this tool on LPS-133314) The tool seems to not like this CSS rules that starts with * made specially for fixing IE7 issues:
*margin-right: .3em;
*line-height: 2em;
*line-height: 1em;
We need to remove this rules form this file: https://github.com/liferay/alloy-font-awesome/blob/master/scss/_mixins-alloy.scss
Once we have a new version generated for liferay-font-awesome with the previous changes done, we need to update in our modules package.json
Steps:
1. Start bundle go to Control Panel > Configuration > System settings > Platform >Third Party > Font Awesome > check Enable Font Awesome > Update
2. Refresh the page and open in a new tab this CSS file /o/frontend-theme-font-awesome-web/css/main.css
3. Check in this file for rules that start with "*margin" or "*line"
Actual: There are CSS files that contains rules that starts with *, these rules are fixes for IE7 that we don't support any more, and it should be removed as we have clients that complain about their accessibility tests failing cause of it.
Expected: There are no more rules starting with * in /o/frontend-theme-font-awesome-web/css/main.css file once Font Awesome was enabled.
Attachments
Issue Links
- fixes
-
LPS-133314 Accessibility errors on search page portlet using OAW tool
- Closed