Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-136078

Prepend "Found {index - 1} formatting issues:" for all SF errors

    Details

      Description

      Expected output:

      format-source-files:
           [java] java.lang.Exception: Found 1 formatting issues:
      ...

      Example

      Actual output:

      format-source-files:
           [java] java.lang.Exception: At least one...

      Example

      CI looks for the text "formatting issues" to display the correct console text snippet in GitHub comments. Here' an Example of an output that doesn't help the developer quickly diagnose the issue:

           [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:287)
      [stopwatch] [run.batch.test.action: 1:53.643 sec]
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1

      This particular case is from [JIRAUtil.java|formatter/src/main/java/com/liferay/source/formatter/util/JIRAUtil.java]. Please also look for other checks that need "Found {index - 1} formatting issues"

        Attachments

          Activity

            People

            Assignee:
            hugo.huijser Hugo Huijser
            Reporter:
            jason.pince Jason Pince
            Engineering Assignee:
            Alan Huang
            Recent user:
            Alan Huang
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Packages

                Version Package