JS error on OAuth2 scopes page (Uncaught TypeError: checkbox.val is not a function)

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.4.13 DXP GA1, Master
• Component/s: Application Security > OAuth2
• Labels:
  • QA-AUTOMATION
  • appsec-qa
  • pt-app-security-review
• Fix Priority: 4
• Sprint: AppSec Iteration 68, AppSec Iteration 69
• Git Pull Request: https://github.com/liferay-appsec/liferay-portal/pull/464
• QA Test Name:
  • LocalFile.OAuth2#ViewAuthPromptRequestedScopes
• QA Test Score: 5

Summary
 Opening the OAuth2 Scopes tab via a direct link for any OAuth2 application will result in a JS error, and the user will not see any selectable scopes.

Test Setup

1. Login to portal as Instance admin
2. Navigate to System Settings / OAuth 2 / Bundle PrefixHandlerFactory
3. Delete the configuration named "Default"

Repro steps

1. Use the direct link to open the Analytics cloud Oauth 2 Application's setup page
2. Login to portal as Instance admin
3. Open the web browser's dev tools to see the javascript error
   
4. Navigate back to OAuth2 Administration panel
5. Select "Analytics cloud" application
6. Open it's Scopes tab
7. Verify there are no visible scopes
   

Expected results
Scopes should be loaded properly without any javascript errors on the page

Actual results
Scopes are not rendering when the user switches to a different OAuth2 application first error is:

manage?p_p_id=com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet&p_p_lifecycle=0&p_p_state=maximized&p_p_mode=view&_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_mvcRenderCommandName=%2Foauth2_provider%2Fassign_scopes&_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_redirect=http%3A%2F%2Flocalhost%3A8080%2Fgroup%2Fcontrol_panel%2Fmanage%3Fp_p_id%3Dcom_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet%26p_p_lifecycle%3D0%26p_p_state%3Dmaximized%26p_p_mode%3Dview%26_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_cur%3D1%26_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_delta%3D20&_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_navigation=assign_scopes&_com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_oAuth2ApplicationId=2:26007 Uncaught TypeError: checkbox.val is not a function
    at _com_liferay_oauth2_provider_web_internal_portlet_OAuth2AdminPortlet_recalculateDependants