Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-139384

Alloyeditor button-paragraph-align.jsx displays always left icon alignment when has an image next to selected text

    Details

    • Type: Bug
    • Status: Verified
    • Resolution: Unresolved
    • Affects Version/s: 7.2.X, 7.3.X
    • Fix Version/s: None
    • Component/s: CKEditor
    • Labels:
      None
    • Fix Priority:
      3

      Description

      According to this comment: https://github.com/liferay/alloy-editor/pull/1501#pullrequestreview-754482152 

      The case described on LPS-138431 was solved on Alloy Editor side, but we have to check if we can fix on CKEditor side as well. Now for this case the button button-paragraph-align.jsx always displays left alignment icon because of the condition we added to prevent the error.
      activeCommand = activeCommand ? activeCommand : getCommands[0];
      I think is related with the latest changes we have done in CKEditor in justify/plugin.js#L205 refresh: function. But after long debugging I'm kind of trapped, because I don't really manage to understand why on the case described, the refresh function{{/core/editor.js#L249 is being called for all four commands, but is only executed for justifyblock command and not for the rest tree.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              georgel.pop Georgel Vasile Pop
              Participants of an Issue:
              Recent user:
              Liferay JIRA Bot
              Engineering Assignee:
              Georgel Vasile Pop
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Days since last comment:
                35 weeks ago

                  Packages

                  Version Package