The option to forcibly disable staging doesn't work

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.X, Master
• Fix Version/s: 7.3.10.3 DXP SP3, 7.3.X, 7.4.13 DXP GA1, 7.4.3.4 CE GA4, Master
• Component/s: Content Publishing > Staging
• Labels:
  • ee-ts
  • liferay-dxp-73-sp3
  • liferay-fix-pack-dxp-3-7310
  • liferay-fixpack-dxp-3-7310
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Story Points: 3
• Fix Priority: 3
• Git Pull Request: https://github.com/vendeltoreki/liferay-portal/pull/229

Description
The purpose of the option to forcibly disable staging is to allow staging to be disabled even when the connection to the remote live site can't be established. However, this isn't working currently. When you select the option to forcibly disable remote staging, Liferay will still attempt to connect to the remote live site and fail if it cannot establish a connection.

This is happening because we don't properly set the "stagingType" parameter during the request to forcibly disable staging. The parameter should be set to TYPE_NOT_STAGED to communicate that we want the site to be unstaged, but it is instead set to TYPE_REMOTE_STAGING which tells the backend that we want to enable remote staging (which requires it to make requests to the remote live site).

Steps to Reproduce
1. Configure 2 instances of Liferay with different IP/ports and shared tunnel secrets in portal-ext, e.g.

tunneling.servlet.shared.secret=6162636465666768696a6b6c6d6e6f70
tunneling.servlet.shared.secret.hex=true

2. Start each instance
3. Configure first instance to remote stage with 2nd instance
4. Shut down 2nd instance
5. Attempt to change port # of remote instance in first instance's staging settings. This fails
6. In resulting error message on page, click on 'forcibly disable'
Expected Result: Staging is disabled successfully.
Actual Result: Staging is not disabled, and the following error message appears in the logs:

ERROR [http-nio-8080-exec-1][SiteAdministrationPanelCategoryDisplayContext:212] Unable to connect to remote live: java.net.ConnectException: Connection refused (Connection refused)