'When' combined with 'Then' is being used in both time and condition contexts, causing localization issues

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.4.3.5 CE GA5, 7.4.13 DXP U1, 7.4.3.6 CE GA6, 7.4.13 DXP U2, Master
• Component/s: Objects
• Labels:
  • liferay-update-dxp-1-7413
  • pt-app-security-review
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-objects/liferay-portal/pull/293
• Bug Type: Localization

Steps to reproduce:

1. Navigate to Objects
2. Add a new Event
   • Toggle to another language, like Japanese (might need to be done before clicking to add event, but you'll want to know where the button is first)
3. See the dialog box with Label, When, Then headers over fields, now translated into the target language.

Expected result:
Since English can parse conditional phrases using "if...then" or "when...then", we expect a fitting language key for use in other locales, as well.

Actual result:
Because we're pulling up the language keys for "When" and "Then" from portal-impl's language.properties file, we're causing translation difficulties when those words aren't being used in their time sense.

We'll probably just want a second kind of language key given for 'When' and 'Then', when they're used within Objects. Perhaps: 'objects-when', 'objects-then'