Deactivated users are counted in Roles page

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.2.10 DXP FP14
• Fix Version/s: 7.4.3.5 CE GA5, 7.4.13 DXP U1, Master
• Component/s: User Management > Roles
• Labels:
  • backend_test
  • ee-ts
  • liferay-update-dxp-1-7413
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-usm/liferay-portal/pull/355
• Bug Type: Code Upgrade

Issue
Deactivated users are counted in Roles page.
This can be seen as a data inconsistency.

Steps to reproduce

1. Start a clean bundle
2. Create 2 new sites: Site1, Site2
3. Create 2 new users: User1, User2
4. Assign User1 to Site1 and User2 to Site2
5. Set them both to "Site Content Reviewer"
6. Go to [CP > Users > Roles > Site Roles]
7. Note Site Content Reviewer has 2 assignees
8. Deactivate User1
9. Go to [Site1 > People > Membership]
10. Note User1 is not displayed anymore (OK)
11. Go to [CP > Users > Roles > Site Roles]
12. Note Site Content Reviewer still has 2 assignees, deactivated user is still counted (NG)
13. Delete User1
14. Go to [CP > Users > Roles > Site Roles]
15. Note Site Content Reviewer has now 1 assignee (OK)

Actual Results
Deactivated users are counted in Roles page

Expected Results
Deactivated users are not counted

Reproduced in
7.2 dxp-14
7.2.x-private (9bc873ac0285433f4176384ec0bae90578fe6a32)
master-private (5e3357a3ea7ec0d7b04586f840755ece5fb09b8e)