Performance issue with Combine Segments in Dynamic Collections

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.4.3.15 CE GA15, Master
• Component/s: Collections > Collections Personalization
• Labels:
  • backend_test
  • liferay-update-dxp-10-7413
• Fix Priority: 3
• Sprint: TANGO | #73 DEV | Feb04-Feb25
• Git Pull Request: https://github.com/liferay-tango/liferay-portal/pull/2212

Description:

After the issue https://issues.liferay.com/browse/LPS-104108 was merged into master,

the assets start appearing twice in the Asset Publisher.

Analyzing this duplication, we have found also that a big performance issue was related with this duplication, because all the assets of all the segments are in memory (where they are sorted).
 

Steps to reproduce:

 

Given a user belonging to Segment 1 and Segment 2
And  the configuration to combine assets is enabled
When  there's a variation of a dynamic collection targeting segment 1 and segment 2
And   there is an asset present in both variations
Then   the user will see the asset only once in Asset Publisher / Collection Display Fragment

 
Actual Result - The asset appears twice in the Asset Publisher / Collection Display Fragment
 

Acceptance Criteria

Acceptance Criteria	Test Strategy
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a manual collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there is an asset present in both variations Then the user will see the asset only once in Asset Publisher	Medium
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a manual collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there is an asset present in both variations** Then the user will see the asset only once in Collection Display Fragment	Medium
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a dynamic collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there is an asset present in both variations** Then the user will see the asset only once in Asset Publisher	Medium
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a dynamic collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there is an asset present in both variations** Then the user will see the asset only once in Collection Display Fragment	Medium
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a manual collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there are some assets present in both variations** Then the assets shown to the user will be ordered according to: The priority of the Variation The priority of the asset established in the Variation	Medium
Given a user belonging to Segment 1 and Segment 2 And the configuration to combine assets is enabled When there's a variation of a dynamic collection targeting segment 1 and segment 2, and both are prioritized above the anyone variation And there are some assets present in both variations** Then the assets shown to the user will be ordered according to: The asset priority (different from the variation priority) The creationDate of the asset	Medium